[15.0][MIG] procurement_purchase_no_grouping: Migration to 15.0#1526
Merged
OCA-git-bot merged 26 commits intoOCA:15.0from Jul 17, 2022
Merged
Conversation
…ion to avoid problems on other searches made on same method
Currently translated at 100.0% (8 of 8 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-procurement_purchase_no_grouping Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-procurement_purchase_no_grouping/zh_CN/
When purchase grouping is set to no order grouping, the previously returned domain ensured no other PO is found, but being the same domain for all will make that they are grouped together in a batch operation, like the creation of all procurements from a confirmed sales order. Steps to reproduce: * Create 2 products with MTO and different vendors. * Add both in a sales order. * Confirm the sales order. * One purchase order is created for both products instead of 2, more even in this case that they have different vendors. Fixes OCA#975
…red_purchase_grouping field
Steps to reproduce: - Create a product with MTO route and "No line grouping" product category. - Create an SO with such product and quantity = 1. - Confirm it. - A purchase order is created with such product and qty = 1. - Edit the sales order, and change quantity = 2. Current behavior: A new purchase line is created with quantity = 2, having ordered 3 units instead of 2. Expected behavior: The same existing purchase line is updated with quantity = 2. ------ For solving this problem, we are going to group by procurement group instead of simply discarding any possible line grouping. NOTE: This makes that if you manually assign the same procurement group to several different sales orders, the grouping will be done no matter the grouping criteria, but this is the only way to do it without having to put a lot of glue modules, and on standard operation mode, procurement groups are not reused between sales orders. TT33031
Contributor
Author
|
@CarlosRoca13 please review |
CarlosRoca13
approved these changes
Jul 13, 2022
Contributor
Author
|
@Tardo can you review? |
Contributor
Author
|
@pedrobaeza could you please review? |
Contributor
Author
|
@sergio-teruel could you review? |
Member
|
/ocabot migration procurement_purchase_no_grouping |
78 tasks
pedrobaeza
approved these changes
Jul 16, 2022
| class TestProcurementPurchaseNoGrouping(common.SavepointCase): | ||
| @classmethod | ||
| def setUpClass(cls): | ||
| super(TestProcurementPurchaseNoGrouping, cls).setUpClass() |
Member
There was a problem hiding this comment.
Suggested change
| super(TestProcurementPurchaseNoGrouping, cls).setUpClass() | |
| super().setUpClass() |
Contributor
|
This PR has the |
Member
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 6d4268d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT36490